Copilot commented on code in PR #2890:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2890#discussion_r4089076345
##########
internal/provider/apisix/status.go:
##########
@@ -121,13 +152,21 @@ func (d *apisixProvider) classifySyncResult(
anyUnattributed := false
for _, syncStatus := range addrErr.FailedStatuses {
+ reason := fmt.Sprintf("ServerAddr: %s, Error:
%s", addrErr.ServerAddr, syncStatus.Reason)
+ if key, ex, ok := d.dropUnit(configName,
syncStatus.Event); ok {
+ if previous, ok := dropped[key]; ok {
+ reason = previous.reason + "; "
+ reason
+ }
+ ex.reason = reason
+ dropped[key] = ex
+ continue
Review Comment:
A resource-attributed rejection still marks the GatewayProxy unavailable
here. `endpointMsg` is appended before this branch, and real 422 responses
carry `EndpointStatuses` with `success:false` that restate the same rejection
(`internal/adc/client/executor_test.go:311-335`). Consequently
`gatewayProxyMsgs` remains non-empty even when every failed status is
successfully converted into an exclusion, contrary to this PR's requirement
that a named resource rejection not fail the GatewayProxy. Filter endpoint
failures that merely duplicate an attributed rejection while retaining
independent transport/instance failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
