membphis commented on a change in pull request #693:
URL: https://github.com/apache/apisix-dashboard/pull/693#discussion_r517830945
##########
File path: api/conf/conf.yaml
##########
@@ -14,12 +14,23 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-version: '3'
+# PLEASE DO NOT UPDATE THIS FILE!
Review comment:
it makes me confused, please confirm we need those warning message
##########
File path: api/conf/conf.yaml
##########
@@ -14,12 +14,23 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-version: '3'
+# PLEASE DO NOT UPDATE THIS FILE!
+# If you want to set the specified configuration value, you can set the new
+# value in the conf/config.yaml file.
+#
-services:
- manager:
- image: golang:1.13.8
- volumes:
- - .:/go/src/github.com/apisix/manager-api
- working_dir: /go/src/github.com/apisix/manager-api
- command: go test -v github.com/apisix/manager-api/service
+conf:
+ listen:
+ host: 127.0.0.1
+ port: 8080
+ etcd:
+ endpoints:
+ - 127.0.0.1:2379
+authentication:
+ secret: secret
Review comment:
why we need this configuration?
##########
File path: api/test/docker/manager-api-conf.yaml
##########
@@ -0,0 +1,39 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# PLEASE DO NOT UPDATE THIS FILE!
+# If you want to set the specified configuration value, you can set the new
+# value in the conf/config.yaml file.
+#
+
+conf:
+ listen:
+ host: 0.0.0.0
+ port: 8080
+ dag_lib_path: ''
Review comment:
do we need to delete this line too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
