Arjen10 commented on code in PR #14012:
URL: https://github.com/apache/apisix/pull/14012#discussion_r4214230026
##########
apisix/plugins/splunk-hec-logging.lua:
##########
@@ -171,11 +171,15 @@ local function send_to_splunk(conf, entries)
if res.status ~= 200 then
local body = core.json.decode(res.body)
- if not body then
- return false, "failed to send splunk, http status code: " ..
res.status
+ local err_msg
+ if type(body) == "table" and (body.text or body.message) then
Review Comment:
CI error: `ERROR: apisix/plugins/splunk-hec-logging.lua: line 175: getting
the Lua global "type"`. The local type should be replaced with a cached global,
`local type = type`, so that `lj-releng` no longer reports this error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
