AlinsRan commented on code in PR #2882:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2882#discussion_r4244455423
##########
Makefile:
##########
@@ -29,7 +29,7 @@ KIND_NAME ?= apisix-ingress-cluster
CLOUD_PROVIDER_KIND_VERSION ?= v0.6.0
CLOUD_PROVIDER_KIND_PID ?= /tmp/cloud-provider-kind.pid
-ADC_VERSION ?= 0.30.5
+ADC_VERSION ?= 0.31.0
Review Comment:
Correct, and fixed in 3b6363d3.
```yaml
# config/manager/kustomization.yaml
- name: sidecar
newName: ghcr.io/api7/adc
newTag: 0.31.0
```
`ADC_VERSION` only reaches the manifest through `kustomize edit set image`
in the `deploy` targets, so a plain `kustomize build config/default` kept
shipping 0.30.5 — which rejects both new fields. It was also the last `0.30.5`
left in the tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
