AlinsRan opened a new pull request, #1023: URL: https://github.com/apache/apisix-helm-chart/pull/1023
Fixes #921 ### Problem When `ingress-controller.enabled=true`, the ConfigMap template always appended `0.0.0.0/0` to `deployment.admin.allow_admin`, regardless of `apisix.admin.allow.ipList`. Any user-defined restriction was silently overridden, and IPv6 clients (e.g. the ingress controller on an IPv6/dual-stack cluster) were never allowed. ### Change `apisix.admin.allow.ipList` now defaults to `null`, which lets the template distinguish "not configured" from "configured by the user": | `ipList` | ingress-controller disabled | ingress-controller enabled | |---|---|---| | unset (default) | `127.0.0.1/24` | `127.0.0.1/24`, `0.0.0.0/0`, `::/0` | | non-empty list | as configured | as configured (nothing appended) | | `[]` | `0.0.0.0/0` | `0.0.0.0/0` | - Default installs render the same as before (plus `::/0` when ingress-controller is enabled, so it works on IPv6 clusters). - The empty-list behavior is unchanged. - Chart version bumped to 2.18.2; README regenerated with helm-docs. ### Upgrade note Users who set a custom `ipList` **and** enable the ingress-controller sub-chart must now include the ingress-controller Pod CIDR (or `0.0.0.0/0` / `::/0`) in `ipList` themselves; previously it was added implicitly. ### Verification `helm lint` passes, and `helm template` renders the expected `allow_admin` for each row in the table above. With default values the output is identical to master apart from the chart version label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
