ruanweihong-aaa commented on PR #13655:
URL: https://github.com/apache/apisix/pull/13655#issuecomment-6356102065

   Thanks for working on this. It looks like the issue addressed here has 
already been covered by #13876, merged as 
77086b0db0dc91a120d0aa21834e6e41e4823d93 and included in 3.19.0.
   
   The corresponding code is already present in the release:
   
   - [The `output_sent` 
guard](https://github.com/apache/apisix/blob/473043623c161966f3f6ef4e8f12d2d8667a12d2/apisix/plugins/ai-providers/base.lua#L590-L607)
 returns without a new HTTP status after partial output. Only a read failure 
before downstream output reaches `transport_http.handle_error(err)`.
   - [Broken upstream connection 
cleanup](https://github.com/apache/apisix/blob/473043623c161966f3f6ef4e8f12d2d8667a12d2/apisix/plugins/ai-providers/base.lua#L584-L589)
 closes the connection rather than returning it to the keepalive pool.
   - [The regression 
tests](https://github.com/apache/apisix/blob/473043623c161966f3f6ef4e8f12d2d8667a12d2/t/plugin/ai-proxy-stream-truncated.t)
 cover preserving the committed response after a read error (TEST 2), avoiding 
fallback after partial output (TEST 4), and retaining fallback before the first 
downstream byte (TEST 6).
   
   Could we close this PR as superseded by #13876?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to