hanzhenfang commented on PR #14043:
URL: https://github.com/apache/apisix/pull/14043#issuecomment-6397851503
Thanks for the PR, @bhuvan-somisetty!
Could we also invalidate the legacy `post_arg_` variables here? `core.ctx`
caches `post_arg_foo` in the same `var._cache`, but the invalidation loop only
clears the `post_arg.` prefix.
After reading `ctx.var.post_arg_foo` and then calling
`ngx.req.set_body_data("foo=updated")`, the cached variable can still return
the original value even though `req_post_args` has been cleared. This appears
to be another path of the existing cache-invalidation issue, rather than a
regression introduced by this PR.
Please cover both prefixes and add a regression case that reads
`post_arg_foo` before and after the rewrite. This observation is based on
source review of `f408d4a6`; I have not run this case locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
