hanzhenfang commented on PR #13302: URL: https://github.com/apache/apisix/pull/13302#issuecomment-6397853743
Thanks for the PR, @venkatapgummadi! The schema allows `watch_retry_interval_seconds = 0`, but a failed `list_watch` then reaches the "Success: reset" branch and schedules another zero-delay timer. This never backs off, even when `watch_retry_max_seconds` is positive. Could we either require a positive initial interval, or explicitly define and test zero as disabling backoff? Could we also add tests around `start_fetch` that assert the scheduled delays for failures/exceptions, the cap, and reset after success? The new tests currently cover validation and option propagation, but do not exercise this retry loop. This observation is based on source review of `a4a17ae3`; I have not run the retry scenario locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
