AlinsRan commented on PR #14101:
URL: https://github.com/apache/apisix/pull/14101#issuecomment-6436687773

   Thanks for the reproduction. Agreed that this is real and only happens when 
`prometheus-metrics` is full and LRU eviction drops a baseline while its 
counter survives. It may be worse than an occasional replay: each collection 
touches the baselines before `metric_data()` reads the counters, so the 
baselines are the first to be evicted, and writing a replayed baseline back 
into the full dict can evict the next one.
   
   I'd like to keep this PR scoped to the missed first-session bytes and track 
the eviction case separately in #14103, with a dedicated non-evicting baseline 
dict as the likely fix and a regression test for repeated baseline loss.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to