GitNimay commented on issue #14051: URL: https://github.com/apache/apisix/issues/14051#issuecomment-6538748081
@jjansenvr thanks for pointing it out. #11629 adds request body support (`with_body`, issue #11387) and is still being worked on by its author, while this change only adds the `traceparent` header to the OPA request, so I'd keep them as two separate PRs. That way each one can be reviewed and merged on its own. I've updated #14059 so the two don't get in each other's way: my test file is now `t/plugin/opa5.t` (#11629 also adds `opa4.t`) and the docs note moved to a spot #11629 doesn't touch. I checked with `git merge-tree`, and the two PRs now merge cleanly in either order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
