jlaupa commented on PR #13707: URL: https://github.com/apache/apisix/pull/13707#issuecomment-6633655204
@membphis thanks for the review, all three points were real bugs. They're fixed in b3dd0f5, each with a test that fails on `b6ef18c7` and passes now: - **Stale key after a slow secret lookup:** applying a change no longer resolves secrets. A secret-backed update marks that plugin's key map dirty, and a map built while a newer update landed is discarded. Test: TEST 29 in `t/node/consumer-incremental-rebuild.t`. - **Snapshot replacements not revoking:** a new `consumers.values` table now triggers delete reconciliation on the next lookup. Tests: `consumer-incremental-rebuild-standalone.t` (Admin API) and `consumer-incremental-rebuild-file.t` (YAML/JSON reload). - **Cross-plugin secret reads:** each plugin rebuilds only its own map, so key-auth no longer resolves basic-auth secrets. Test: TEST 30. I also fixed a regression the previous head had: it applied key changes even when `modifiedIndex` didn't change, unlike master (caught by `admin/standalone.spec.ts`). CI is green now. I also updated the description with a fresh benchmark of this head against current master, same setup for both. With 50k consumers and Admin API writes during traffic, master drops to 0.1 rps and completes 1 of 500 creates, while this PR keeps serving 593 rps with p99 at 24 ms. @membphis @bzp2010 could you take another look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
