AlinsRan commented on code in PR #14057:
URL: https://github.com/apache/apisix/pull/14057#discussion_r4451786650


##########
apisix/init.lua:
##########
@@ -522,14 +522,14 @@ local function skip_mtls(ssl, ctx)
 end
 
 
-local function verify_https_client(ctx)
+function _M.verify_https_client(ctx)

Review Comment:
   Exporting a private function solely for this test seems unnecessary.
   
   The regression test should reproduce the reported nil dereference through a 
real HTTPS request, fail on base, and pass with the fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to