AlinsRan commented on PR #14162: URL: https://github.com/apache/apisix/pull/14162#issuecomment-6680099474
@nic-6443 Thanks. I've updated the PR as you suggested (8131b5ed): - `write_marker` is removed from the CLI schema, the default config, `config.yaml.example` and the docs. `encrypt_conf` now always writes `$ENC$v1$...`. - On read, the `encrypt_fields` path runs first and skips marked values. A single in-place recursive pass then decrypts every `$ENC$v1$` string. It is called from `plugin_checker`, `stream_plugin_checker` and `check_plugin_metadata` (after the schema check, as on master), and from the Admin API reads and PATCH. - A marked value that fails to decrypt is logged and kept as it is. The resource stays valid. - Removed: the reserved-prefix rejection, the PATCH restore logic and the `resource.lua` changes, the all-or-nothing decryption, the `marked` argument, the metadata copy, and decryption of the plugin metadata list. - The info log changes in `http/route.lua`, `http/service.lua`, `init.lua`, `utils/log-util.lua` and `plugin.lua` are out of this PR. - Existing tests that compare stored ciphertext now expect the marked form. The description has a release note with your wording. @membphis Correction to my earlier comments: plugin metadata is no longer decrypted on a copy. As on master, it is decrypted after its schema check passes, so a rejected entry is still logged with its values encrypted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
