moonming commented on PR #326:
URL:
https://github.com/apache/apisix-java-plugin-runner/pull/326#issuecomment-6733514996
Added regression coverage and clarified the buffer-lifetime comment in
194720f.
- Added two deterministic `PostFilterTest` cases covering response-body and
Nginx-variable extra-info round trips through the actual binary/payload
decoders. They verify the input buffer has been released, overwrite its backing
memory, then assert the original upstream headers/status and successful filter
completion.
- Extended the existing real APISIX E2E test to assert the upstream status
and Content-Type read by the post-filter after extra-info fetching.
- Clarified that the underlying problem is the lifetime of the shared
backing buffer.
Validation:
- Java 21: `mvn -B -pl runner-core -am test -Dgpg.skip=true` — 39 tests
passed, 0 failures/errors/skips.
- Negative control: restoring the complete pre-PR `RpcCallHandler` makes
both new regression cases fail (`{x-upstream=original}` becomes `{}`); both
pass with the fix.
- `go test ./... -count=1 -v` — all 8 real E2E specs passed against APISIX
3.19.0, etcd 3.5.15, the Java runner, and the existing HTTP echo upstream. No
network stubs were used.
A cold independent audit of the pushed commit found no HIGH/MEDIUM findings.
The two GitHub CI workflows have also been approved to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
