kayx23 commented on code in PR #14067: URL: https://github.com/apache/apisix/pull/14067#discussion_r4522188957
########## docs/en/latest/plugins/grpc-transcode.md: ########## @@ -83,6 +83,8 @@ docker run -d \ api7/grpc-server-example:1.0.2 ``` +These examples use `127.0.0.1:50051` as the upstream address and assume APISIX runs on the Docker host. If APISIX runs in a container, connect both containers to the same [user-defined Docker network](https://docs.docker.com/engine/network/drivers/bridge/) and replace `127.0.0.1:50051` in the Route configurations with `grpc-example-server:50051`. Inside the APISIX container, `127.0.0.1` refers to APISIX itself; Docker resolves the upstream container name on the shared network. Review Comment: Addressed: the current head removes the `grpc-transcode` changes entirely, leaving #14048 as the canonical correction. I verified that `docs/en/latest/plugins/grpc-transcode.md` and its Chinese counterpart are no longer part of this PR diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
