moonming opened a new pull request, #1035:
URL: https://github.com/apache/apisix-helm-chart/pull/1035
## What
Adds `gatewayProxy.name` to the apisix-ingress-controller chart. It names
the GatewayProxy that the IngressClass references and defaults to `<release
name>-config`, so existing values render the same. It is rendered with `tpl`.
With `createDefault: false`, setting `name` makes the IngressClass reference
a GatewayProxy that this chart does not create.
Version: 1.4.1 → 1.5.0.
## Why
The apisix chart needs to create the GatewayProxy for the bundled controller
itself. Only the apisix chart knows the Admin API Service name
(`<fullname>-admin`) and where the admin key is stored (an inline value, an
existing Secret, or a Secret it generates). Today users have to repeat that by
hand under `ingress-controller.gatewayProxy`, and when the two copies differ
the controller cannot reach APISIX (#908).
The apisix chart change follows in a separate PR, because it can only depend
on this chart after 1.5.0 is released.
## Compatibility
- `name` defaults to `""`, which keeps `<release name>-config` for both the
created GatewayProxy and the IngressClass reference.
- With default values and with `createDefault: true`, `helm template` gives
the same output as 1.4.1, apart from the webhook certificates, which are
regenerated on every render.
## Testing
- `helm template` (Helm 4.2.4):
- default values: unchanged;
- `createDefault: true`: unchanged;
- `createDefault: false` + `name: "{{ .Release.Name }}-config"`: no
GatewayProxy, IngressClass references `<release>-config`;
- `createDefault: true` + `name: custom`: both the GatewayProxy and the
IngressClass use `custom`.
- `ct lint` (chart-testing v3.13.0) passes.
- The apisix chart PR uses this in its render tests and in an end-to-end
test on kind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
