moonming opened a new issue, #1049:
URL: https://github.com/apache/apisix-helm-chart/issues/1049

   ## Description
   
   With bundled etcd enabled, APISIX's ConfigMap and `wait-etcd` init container 
calculate the etcd hostname as `<release>-etcd` unless `etcd.fullnameOverride` 
is set. The bundled etcd chart uses `common.names.fullname`, which also handles 
`nameOverride` and reuses the release name when it already contains the chart 
name.
   
   These calculations disagree for otherwise valid release names and values:
   
   | Release | Values | etcd Service | APISIX / wait-etcd target |
   | --- | --- | --- | --- |
   | `demo` | `etcd.nameOverride=store` | `demo-store` | `demo-etcd` |
   | `demo-etcd` | defaults | `demo-etcd` | `demo-etcd-etcd` |
   
   The init container targets a Service that the chart does not create. The 
APISIX configuration contains the same incorrect hostname.
   
   ## Expected behavior
   
   Both the APISIX configuration and `wait-etcd` should use the actual Service 
name of the bundled etcd chart, including its name overrides and release-name 
handling.
   
   ## Source
   
   This is present on master at `acd25584395d905511b68a20420bddf2bbd71a80` 
(APISIX chart `2.19.0`, appVersion `3.20.0`):
   
   - [ConfigMap 
hostname](https://github.com/apache/apisix-helm-chart/blob/acd25584395d905511b68a20420bddf2bbd71a80/charts/apisix/templates/configmap.yaml#L422)
   - [`wait-etcd` 
hostname](https://github.com/apache/apisix-helm-chart/blob/acd25584395d905511b68a20420bddf2bbd71a80/charts/apisix/templates/deployment.yaml#L261)
   - [Bundled etcd 
chart](https://github.com/apache/apisix-helm-chart/blob/acd25584395d905511b68a20420bddf2bbd71a80/charts/apisix/charts/etcd-12.0.18.tgz):
 `etcd/templates/svc.yaml:10` uses `common.names.fullname`; 
`etcd/charts/common/templates/_names.tpl:26-38` implements the name-override 
and release-name rules.
   
   Setting `etcd.fullnameOverride` to an explicit Service name is a workaround 
for these two cases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to