AlinsRan commented on PR #14157: URL: https://github.com/apache/apisix/pull/14157#issuecomment-6904464329
Addressed in f1ced0686: - The `item_schema` failure branches (single item full load, directory full load, watch) now log the key only, same as the checker branches. - `check_single_plugin_schema` and `stream_check_schema` report the type of a non-table plugin conf (`invalid plugin conf type string for plugin [x]`) instead of its value. This changes the Admin API error text for that case; the `basic-auth.t` / `ldap-auth.t` expectations are updated accordingly. - `t/node/plugin-conf-log-secret.t` TEST 9–12 add watch and cold-start cases that fail at `item_schema` and at a non-table plugin conf, asserting the plaintext secret is absent from `error.log`. All four fail on the previous head with the secret in the log. The `invalid item data ... val: ..., it should be an object` lines for a non-table resource value are kept unchanged: that value is not a plugin configuration, and existing tests assert the message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
