membphis commented on a change in pull request #2657:
URL: https://github.com/apache/apisix/pull/2657#discussion_r519373662



##########
File path: apisix/plugins/jwt-auth.lua
##########
@@ -53,7 +53,7 @@ local consumer_schema = {
             enum = {"HS256", "HS512", "RS256"},
             default = "HS256"
         },
-        exp = {type = "integer", minimum = 1},
+        exp = {type = "integer", minimum = 1, default = 86400},

Review comment:
       and we need to add a test case to check the default value, we need to 
sure it works.
   
   and we need a test case for this case: 
https://github.com/apache/apisix/issues/2649
   
   we need to sure we fixed this bug.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to