membphis commented on a change in pull request #729: URL: https://github.com/apache/apisix-dashboard/pull/729#discussion_r519727291
########## File path: README.md ########## @@ -27,15 +27,21 @@ Dashboard for [Apache APISIX](https://github.com/apache/apisix) Please refer to [User Guide](./docs/USER_GUIDE.md) -## Deployment +## For Developer -- [Deploy Manually](./docs/deploy.md) -- [Deploy with Docker](./docs/deploy-with-docker.md) +If you are a developer, please refer to start manager-api and Web separately -## Development +- [dependencies](#dependencies) +- [develop Dashboard](./docs/develop.md) -- [Apache APISIX](https://github.com/apache/apisix) -- [Dashboard](./docs/develop.md) +## deployment + +- [one click with Docker](./docs/deploy-with-docker.md) +- [build from source code](./docs/deploy.md) + +## dependencies Review comment: keep the same name style:  ########## File path: docs/deploy.zh-CN.md ########## @@ -102,6 +102,14 @@ $ ./api/run.sh & $ kill $(ps aux | grep 'manager-api' | awk '{print $2}') ``` +## 打包 + +你可以把刚刚 output 目录整体打包，copy 到其他地方解压运行，output 目录包含运行 dashboard 需要的所有文件(配置文件、可执行文件、web静态资源) + +```sh +$ tar –cvf dashboard.tar ./output/* Review comment: should use `makefile`, take a look at: https://github.com/apache/apisix/blob/master/Makefile#L200 ########## File path: docs/deploy.md ########## @@ -104,14 +87,29 @@ authentication: password: user ``` -2. Run manager-api +2. Run ```sh -$ api/run.sh & +$ cd ./output +$ export ENV=local && exec ./manager-api Review comment: confused too ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
