LiteSun commented on a change in pull request #736:
URL: https://github.com/apache/apisix-dashboard/pull/736#discussion_r519972428
##########
File path: web/src/helpers.tsx
##########
@@ -96,3 +97,12 @@ export const getUrlQuery: (key: string) => string | false =
(key: string) => {
}
return false;
};
+
+export const timestampToLocaleString = (timestamp: number) => {
+ if (!timestamp) {
+ // TODO: i18n
+ return "None"
Review comment:
I think it's wired to show text `None` in the time column and some of
user maybe don't know what's it mean. How about return empty string ``?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
