juzhiyuan commented on a change in pull request #2706: URL: https://github.com/apache/apisix/pull/2706#discussion_r522609318
########## File path: doc/plugins.md ########## @@ -21,14 +21,17 @@ ## Hot reload -APISIX plug-ins are hot-loaded. No matter you add, delete or modify plug-ins, you don't need to restart the service. +APISIX plugins are hot-loaded. No matter you add, delete or modify plugins, you don't need to restart the service. If your APISIX node has the Admin API turned on, just send an HTTP request through admin API: ```shell curl http://127.0.0.1:9080/apisix/admin/plugins/reload -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT ``` +Note: if you disable a plugin which has been configured as part of your rule (in the `plugins` field of `route`, etc.), +the its execution will be skipped. Review comment: Please remove `the` ########## File path: doc/plugins.md ########## @@ -21,14 +21,17 @@ ## Hot reload -APISIX plug-ins are hot-loaded. No matter you add, delete or modify plug-ins, you don't need to restart the service. +APISIX plugins are hot-loaded. No matter you add, delete or modify plugins, you don't need to restart the service. If your APISIX node has the Admin API turned on, just send an HTTP request through admin API: ```shell curl http://127.0.0.1:9080/apisix/admin/plugins/reload -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT ``` +Note: if you disable a plugin which has been configured as part of your rule (in the `plugins` field of `route`, etc.), +the its execution will be skipped. Review comment: Or use then instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
