Firstsawyou commented on a change in pull request #2744:
URL: https://github.com/apache/apisix/pull/2744#discussion_r523405550



##########
File path: doc/zh-cn/architecture-design.md
##########
@@ -194,6 +194,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/102 -H 
'X-API-KEY: edd1c9f034335f
 
 在 `conf/config.yaml` 中,可以声明本地 APISIX 节点都支持哪些插件。这是个白名单机制,不在该
 白名单的插件配置,都将会被自动忽略。这个特性可用于临时关闭或打开特定插件,应对突发情况非常有效。
+如果你想在现有插件的基础上新增插件,注意需要拷贝 `config-default.yaml` 的插件节点内容到 `conf/config.yaml` 
的插件节点中。

Review comment:
       ditto.

##########
File path: doc/architecture-design.md
##########
@@ -188,7 +188,7 @@ Note: When both Route and Service enable the same plugin, 
the Route parameter ha
 
 The `Plugin` configuration can be bound directly to `Route` or it can be bound 
to `Service` or `Consumer`. For the configuration of the same plugin, only one 
copy is valid, and the configuration selection priority is always `Consumer` > 
`Route` > `Service`.
 
-In `conf/config.yaml`, you can declare which plugins are supported by the 
local APISIX node. This is a whitelisting mechanism. Plugins that are not in 
this whitelist will be automatically ignored. This feature can be used to 
temporarily turn off or turn on specific plugins, which is very effective in 
dealing with unexpected situations.
+In `conf/config.yaml`, you can declare which plugins are supported by the 
local APISIX node. This is a whitelisting mechanism. Plugins that are not in 
this whitelist will be automatically ignored. This feature can be used to 
temporarily turn off or turn on specific plugins, which is very effective in 
dealing with unexpected situations. If you want to add new plugins based on 
existing plugins, you need to copy the `plugins` node content of 
`config-default.yaml` to the `plugins` node of `conf/config.yaml`.

Review comment:
       I think `config-default.yaml` is changed to `conf/config-default.yaml`. 
This is better, keep it consistent with `conf/config.yaml`, and also indicate 
in which directory the `config-default.yaml` file is located. What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to