gxthrj commented on a change in pull request #807:
URL: https://github.com/apache/apisix-dashboard/pull/807#discussion_r524300851
##########
File path: Makefile
##########
@@ -91,5 +93,10 @@ endif
.PHONY: release
release:
- tar –cf dashboard.tar ./output/*
+ tar -zcvf $(RELEASE).tgz ./output/*
Review comment:
Ok, It seems that `make release` should not be used here.
The `output` directory is not source code. They are the result of
compilation, including manager and web.
Maybe `make publish` is more suitable. Ref to some web projects , Such as
elementUI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
