starsz commented on a change in pull request #796:
URL: https://github.com/apache/apisix-dashboard/pull/796#discussion_r526178607
##########
File path: api/test/shell/cli_test.sh
##########
@@ -34,29 +47,47 @@ go build -o ./manager-api .
sleep 3
pkill -f manager-api
-if [[ ! -f "./logs/error.log" ]]; then
- echo "failed: failed to write log"
+check_logfile
+
+if [[ `grep -c "INFO" ${logfile}` -ne '0' ]]; then
+ echo "failed: should not write info log when level is warn"
exit 1
fi
-if [[ `grep -c "INFO" ./logs/error.log` -ne '0' ]]; then
- echo "failed: should not write info log when level is warn"
+clean_logfile
+
+# change level and test signal
+
+sed -i 's/warn/info/' conf/conf.yaml
Review comment:
That's right. Agree with you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
