membphis commented on a change in pull request #2768:
URL: https://github.com/apache/apisix/pull/2768#discussion_r527375571
##########
File path: t/node/upstream-node-dns.t
##########
@@ -519,22 +533,29 @@ location /t {
GET /t
--- grep_error_log eval
qr/dns resolver domain: \w+.com to 127.0.0.\d|call \/hello|proxy request to
127.0.0.\d:1980/
---- grep_error_log_out
-call /hello
-dns resolver domain: test2.com to 127.0.0.1
+--- grep_error_log_out eval
Review comment:
ditoo
##########
File path: t/node/upstream-node-dns.t
##########
@@ -253,20 +253,27 @@ location /t {
GET /t
--- grep_error_log eval
qr/dns resolver domain: \w+.com to 127.0.0.\d|call \/hello|proxy request to
127.0.0.\d:1980/
---- grep_error_log_out
-call /hello
+--- grep_error_log_out eval
Review comment:
Why does this change? Is it also because of openresty 1.19. *?
##########
File path: t/plugin/example.t
##########
@@ -200,7 +200,7 @@ qr/module 'apisix.plugins.not-exist-plugin' not found/
modifiedIndex = 1,
})
- local encode_json = require "cjson.safe" .encode
+ local encode_json = require "toolkit.json" .encode
Review comment:
ditto
##########
File path: t/plugin/example.t
##########
@@ -149,7 +149,7 @@ done
ngx.say("failed to load plugins: ", err)
end
- local encode_json = require "cjson.safe" .encode
+ local encode_json = require "toolkit.json" .encode
Review comment:
`require("toolkit.json").encode`
I think this style is easier to understand
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
