nic-chen commented on a change in pull request #897:
URL: https://github.com/apache/apisix-dashboard/pull/897#discussion_r532121800



##########
File path: api/test/e2e/upstream_test.go
##########
@@ -188,10 +188,63 @@ func TestRoute_Node_Host(t *testing.T) {
        }
 }
 
-//TODO cHash
+func TestUpstream_cHash(t *testing.T) {
+       tests := []HttpTestCase{
+               {
+                       caseDesc: "create cHash upstream",
+                       Object:   MangerApiExpect(t),
+                       Method:   http.MethodPut,
+                       Path:     "/apisix/admin/upstreams/1",
+                       Body: `{
+                "nodes": [{
+                    "host": "172.16.238.20",
+                    "port": 1980,
+                    "weight": 1
+                               },
+                               {
+                    "host": "172.16.238.20",
+                    "port": 1981,
+                    "weight": 2
+                }],
+                               "type": "chash",
+                               "hash_on":"header",

Review comment:
       need cases for different hash_on




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to