idbeta commented on a change in pull request #915:
URL: https://github.com/apache/apisix-dashboard/pull/915#discussion_r532411997
##########
File path: api/internal/core/store/validate.go
##########
@@ -77,8 +77,8 @@ type APISIXJsonSchemaValidator struct {
func NewAPISIXJsonSchemaValidator(jsonPath string) (Validator, error) {
schemaDef := conf.Schema.Get(jsonPath).String()
if schemaDef == "" {
- log.Warnf("scheme validate failed: schema not found, path: %s",
jsonPath)
- return nil, fmt.Errorf("scheme validate failed: schema not
found, path: %s", jsonPath)
+ log.Warnf("schema validate faileded: schema not found, path:
%s", jsonPath)
+ return nil, fmt.Errorf("schema validate faileded: schema not
found, path: %s", jsonPath)
Review comment:
`faileded` -> `failed`
##########
File path: api/internal/core/store/validate.go
##########
@@ -123,25 +123,25 @@ func cHashKeySchemaCheck(upstream *entity.UpstreamDef)
error {
if upstream.HashOn == "vars" {
schemaDef =
conf.Schema.Get("main.upstream_hash_vars_schema").String()
if schemaDef == "" {
- return fmt.Errorf("scheme validate failed: schema not
found, patch: main.upstream_hash_vars_schema")
+ return fmt.Errorf("schema validate faileded: schema not
found, patch: main.upstream_hash_vars_schema")
Review comment:
dido
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
