membphis commented on a change in pull request #2859:
URL: https://github.com/apache/apisix/pull/2859#discussion_r533061349



##########
File path: apisix/plugins/openid-connect.lua
##########
@@ -49,6 +49,7 @@ local schema = {
 local _M = {
     version = 0.1,
     priority = 2599,
+    type = 'auth',

Review comment:
       I found you have submitted new PR: 
https://github.com/apache/apisix/pull/2905/files
   
   Many thanks for your nice job.
   
   Small PR is important, it easy to find problems and we can merge it asap 
when it is small.
   
   By the way, it is a clearer way to show what we are doing.
   
   Many thx for nice contribution again @jenskeiner 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to