spacewander commented on a change in pull request #2901:
URL: https://github.com/apache/apisix/pull/2901#discussion_r533064599
##########
File path: apisix/plugins/http-logger.lua
##########
@@ -169,6 +174,23 @@ local function gen_log_format(metadata)
end
+-- remove stale objects from the memory after timer expires
+local function remove_stale_objects(premature)
+ if premature then
+ return
+ end
+
+ for key, batch in ipairs(buffers) do
+ if #batch.entry_buffer.entries == 0 and #batch.batch_to_process == 0
then
+ core.log.debug("removing batch processor stale object, route id:",
tostring(key))
Review comment:
Better to use a high level log so that we can notice user. What about
using `warn`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
