liuxiran commented on a change in pull request #948:
URL: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533916316
##########
File path: web/src/pages/Route/transform.ts
##########
@@ -82,6 +82,7 @@ export const transformStepData = ({
!Object.keys(step3DataCloned.script || {}).length ? 'script' : '',
form1Data.hosts.filter(Boolean).length === 0 ? 'hosts' : '',
form1Data.redirectOption === 'disabled' ? 'redirect' : '',
+ data.remote_addrs?.filter(Boolean).length === 0 ? 'remote_addrs' : '',
Review comment:
fot the data validation, I agree with @juzhiyuan , this will also be
flexible for people who use api.
If Fe must comply with omit field which is not configed, we may choose more
elegant way to implement this transform, e.g:
write a until func to handle omit params.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
