membphis commented on a change in pull request #2917:
URL: https://github.com/apache/apisix/pull/2917#discussion_r533973235
##########
File path: apisix/core/request.lua
##########
@@ -68,12 +68,25 @@ function _M.header(ctx, name)
end
-function _M.set_header(header_name, header_value)
+function _M.set_header(ctx, header_name, header_value)
+ if type(ctx) == "string" then
+ -- It would be simpler to keep compatibility if we put 'ctx'
+ -- after 'header_value', but the style is too ugly!
Review comment:
how about print a warning message to log?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
