tokers commented on a change in pull request #2943:
URL: https://github.com/apache/apisix/pull/2943#discussion_r535752690
##########
File path: apisix/http/router/radixtree_host_uri.lua
##########
@@ -94,7 +94,14 @@ local function create_radixtree_router(routes)
host_router = nil
for _, route in ipairs(routes or {}) do
+ local status = core.table.try_read_attr(route, "value", "status")
+ if status and status ~= 1 then
Review comment:
magic number is tricky, what about using literal string here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
