juzhiyuan commented on issue #2924: URL: https://github.com/apache/apisix/issues/2924#issuecomment-739144085
Ok fine, let me explain what happened here. The frontend now has to include some hacking codes for array like fields, this change lead to 2 issues: 1. For users, they may find the data has been modified before sending requests, why? what happened? Though it's ok to use that, and no errors would happen, it's a little strange IMO. 2. For developers, we have to leave multiple comments to prevent from confusing for newcomers, or it's too tricky. We shouldn't modify apisix's logics according to comments above. We don't want to modify manager api's logics to prevent from more confusing. We shouldn't add more hacking codes to frontend, and don't have to know what's happened in backend. Then what should we do? Fallback to docs, is it clear enough? 🤔 1. Keep adding hacking codes to frontend, but should support a more clear and semantic docs, it's for developers. The frontend developers only focus on docs, they could develop without having to ask issues for api support. 2. Hacking in manager api, this will take differences from apisix indeed, but will users use apisix directly or manager api directly? The nil and empty array are really different for users? 🤔 I'm not sure, if yes, keep adding hacking codes to frontend is acceptable currently. As for docs, after deprecating admin api, then the docs would call Docs for manager-api, serving for both developers(call api directly) and frontend users. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
