membphis commented on a change in pull request #2943:
URL: https://github.com/apache/apisix/pull/2943#discussion_r536787433
##########
File path: apisix/http/router/radixtree_host_uri.lua
##########
@@ -94,7 +94,11 @@ local function create_radixtree_router(routes)
host_router = nil
for _, route in ipairs(routes or {}) do
- push_host_router(route, host_routes, only_uri_routes)
+ local status = core.table.try_read_attr(route, "value", "status")
+ -- check the status
+ if status == 1 then
Review comment:
The existing old data has no field "status".
we need to make sure it works fine for this case.
`if not status or status == 1 then`, this way is safer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
