ShiningRush commented on a change in pull request #904: URL: https://github.com/apache/apisix-dashboard/pull/904#discussion_r537538857
########## File path: api/internal/core/store/validate_test.go ########## @@ -249,6 +248,30 @@ func TestAPISIXJsonSchemaValidator_checkUpstream(t *testing.T) { assert.EqualError(t, err, "schema validate failed: (root): Does not match pattern '^((uri|server_name|server_addr|request_uri|remote_port|remote_addr|query_string|host|hostname)|arg_[0-9a-zA-z_-]+)$'") } +func TestAPISIXJsonSchemaValidator_Plugin(t *testing.T) { Review comment: This case coverage is too low, it does not cover any failed case : ( ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org