membphis commented on a change in pull request #2932:
URL: https://github.com/apache/apisix/pull/2932#discussion_r539105866
##########
File path: t/node/healthcheck-passive.t
##########
@@ -56,7 +56,7 @@ __DATA__
"interval": 100,
"http_failures": 2
}
- },
+ },]] .. [[
Review comment:
Why do we need to do this? I'm confused.
##########
File path: apisix/core/config_etcd.lua
##########
@@ -484,6 +484,39 @@ function _M.getkey(self, key)
end
+local get_etcd
+do
+ local etcd_cli
+
+ function get_etcd()
+ if etcd_cli == nil then
Review comment:
code style:
```lua
if etcd_cli then
return etcd_cli
end
... ...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
