membphis commented on a change in pull request #2970:
URL: https://github.com/apache/apisix/pull/2970#discussion_r539114644



##########
File path: apisix/plugins/http-logger.lua
##########
@@ -277,6 +277,8 @@ function _M.log(conf, ctx)
         max_retry_count = conf.max_retry_count,
         buffer_duration = conf.buffer_duration,
         inactive_timeout = conf.inactive_timeout,
+        route_id = ctx.route_id,

Review comment:
       for `route_id`, we should ways use `ctx.var.route_id`
   
   it is the recommended way. and please fix similar points.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to