gxthrj commented on a change in pull request #99:
URL: https://github.com/apache/apisix-docker/pull/99#discussion_r540715359
##########
File path: all-in-one/apisix-dashboard/Dockerfile
##########
@@ -0,0 +1,122 @@
+FROM openresty/openresty:alpine-fat AS production-stage
+
+ARG APISIX_VERSION=master
+LABEL apisix_version="${APISIX_VERSION}"
+
+
+RUN set -x \
Review comment:
OK, we can impove it later.
We can write in multiple lines, because these are intermediate processes,
there is no need to consider the size of the image, you can consider adding
some readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]