tokers commented on a change in pull request #3027:
URL: https://github.com/apache/apisix/pull/3027#discussion_r541819314
##########
File path: t/node/invalid-upstream.t
##########
@@ -47,7 +47,7 @@ GET /t
--- grep_error_log eval
qr/\[error\].*/
--- grep_error_log_out eval
-qr{invalid item data of \[/apisix/upstreams/1\], val: mexxxxxxxxxxxxxxx, it
shoud be a object}
+qr{invalid item data of \[/apisix/upstreams/1\], val: mexxxxxxxxxxxxxxx, it
should be a object}
Review comment:
Ditto
##########
File path: t/node/invalid-upstream.t
##########
@@ -63,7 +63,7 @@ GET /not_found
--- grep_error_log eval
qr/\[error\].*/
--- grep_error_log_out eval
-qr{invalid item data of \[/apisix/upstreams/1\], val: mexxxxxxxxxxxxxxx, it
shoud be a object}
+qr{invalid item data of \[/apisix/upstreams/1\], val: mexxxxxxxxxxxxxxx, it
should be a object}
Review comment:
Ditto
##########
File path: t/node/invalid-service.t
##########
@@ -64,7 +64,7 @@ GET /not_found
--- grep_error_log eval
qr/\[error\].*/
--- grep_error_log_out eval
-qr{invalid item data of \[/apisix/services/1\], val: mexxxxxxxxxxxxxxx, it
shoud be a object}
+qr{invalid item data of \[/apisix/services/1\], val: mexxxxxxxxxxxxxxx, it
should be a object}
Review comment:
It should be an object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
