juzhiyuan commented on issue #831: URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743990396
> Websocket is binding with route now > > Ming Wen <[email protected]>于2020年12月13日 周日下午6:47写道： > > > no, FE should not use it in upstream > > > > 琚致远 <[email protected]>于2020年12月13日 周日下午6:30写道： > > > >> The frontend will still use that field for now. > >> > >> — > >> You are receiving this because you commented. > >> Reply to this email directly, view it on GitHub > >> <https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743985080>, > >> or unsubscribe > >> <https://github.com/notifications/unsubscribe-auth/AGJZBK7BI4YGKBU36LZLCL3SUSJTVANCNFSM4T3BLYBA> > >> . > >> > > -- > > Thanks, > > Ming Wen > > Twitter: _WenMing > > > -- > Thanks, > Ming Wen > Twitter: _WenMing > Ok, now i know what happened, i heard from @membphis that this field is bound to Route and called enable_websocket, but when i saw that PR, i didn't see that change is related to upstream_def until you point out. Conclusion: The frontend will use that field with Route instead of Upstream. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
