juzhiyuan commented on a change in pull request #3044:
URL: https://github.com/apache/apisix/pull/3044#discussion_r542989967



##########
File path: conf/apisix.yaml
##########
@@ -19,7 +19,7 @@ routes:
   -
     uri: /hello
     upstream:
-        nodes:
-            "127.0.0.1:1980": 1
-        type: roundrobin
-#END
+      nodes:
+        "127.0.0.1:1980": 1
+      type: roundrobin
+# END

Review comment:
       Not sure, cc @spacewander 

##########
File path: conf/debug.yaml
##########
@@ -28,4 +28,4 @@ hook_phase:                     # module and function list, 
name: hook_phase
     - http_body_filter_phase
     - http_log_phase
 
-#END
+# END

Review comment:
       ,

##########
File path: kubernetes/service-monitor-for-prometheus.yaml
##########
@@ -36,4 +36,3 @@ spec:
       app: apisix-gw
   namespaceSelector:
     any: true
-

Review comment:
       🤔 May need to keep the last line?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to