liuxiran commented on a change in pull request #979:
URL: https://github.com/apache/apisix-dashboard/pull/979#discussion_r543415884
##########
File path: api/test/e2e/route_online_debug_test.go
##########
@@ -42,7 +42,7 @@ func TestRoute_Online_Debug_Route_Not_Exist(t *testing.T) {
testCaseCheck(tc)
}
basepath :=
"http://127.0.0.1:9000/apisix/admin/debug-request-forwarding";
- request, _ := http.NewRequest("POST", basepath,
strings.NewReader(`{"url": "http://172.16.238.30:9080/hello_","method":
"GET"}`))
+ request, _ := http.NewRequest("POST", basepath,
strings.NewReader(`{"url": "http://172.16.238.30:9080/hello_","method":
"GET","protocol": "http"}`))
Review comment:
> can we use `http://172.16.238.30` as a global variable?
I tried `127.0.0.1:9080` at first, but test case Run failed
until I tried this internal IP `172.16.238.30`of Docker, the debug
forwarding request test cases were passed.
I didn't know why actually, maybe it has something to do with our Docker
test environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
