jenskeiner commented on a change in pull request #2903:
URL: https://github.com/apache/apisix/pull/2903#discussion_r544223942
##########
File path: t/plugin/openid-connect.t
##########
@@ -112,7 +112,7 @@ done
},
"upstream": {
"nodes": {
- "127.0.0.1:1980": 1
+ "127.0.0.1:8888": 1
Review comment:
Hey, I'm trying to add tests to check if the plugin sets the headers
correctly as configured. I don't have a local development setup yet, so have to
run the checks on this PR on GitHub to see if it's working.
I switched the upstream port to `8888` since that's where a
`mendhak/http-https-echo` container is running. This one returns in the
response body the full content of the incoming request as a JSON string. So I
think I can check if the plugin has set the headers correctly by checking the
response body. If the tests still work with the new port, I will try to add a
case to do some actual verification of the headers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
