tokers commented on a change in pull request #106:
URL:
https://github.com/apache/apisix-ingress-controller/pull/106#discussion_r545504041
##########
File path: pkg/ingress/endpoint/ep.go
##########
@@ -60,5 +60,12 @@ func BuildEps(ns, name string, port int) []*v1.Node {
}
}
}
+ if len(nodes) < 1 {
Review comment:
That's not a right behavior, if we really cannot collect the endpoint
information, we shouldn't push this upstream to APISIX, instead, logging it and
just throw it away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
