juzhiyuan commented on a change in pull request #949:
URL: https://github.com/apache/apisix-dashboard/pull/949#discussion_r546210483
##########
File path: web/src/pages/Info/locales/en-US.ts
##########
@@ -15,5 +15,5 @@
* limitations under the License.
*/
export default {
- 'page.info.pageContainer.title': 'About Apache APISIX',
+ 'page.info.pageContainer.title': 'Server info',
Review comment:
Info
##########
File path: web/src/pages/Info/service.ts
##########
@@ -19,14 +19,14 @@ import { request } from 'umi';
// Waiting for api.
export const fetchInfoList = () => {
return request<Res<ResListData<NodeListData>>>(
- '/server_info?hostname={hostname}&page_size={page_size}&page={page}',
+ `/server_info`,
Review comment:
''
##########
File path: web/src/pages/Info/typing.d.ts
##########
@@ -15,16 +15,21 @@
* limitations under the License.
*/
type NodeDetail = {
- id: string;
+ id: number;
+ last_report_time: number;
+ up_time: number;
+ boot_time: number;
+ etcd_version: string;
hostname: string;
version: string;
- etcd_version: string;
- uptime: number;
- last_report_at: number;
- boot_time: number;
};
type NodeListData = {
Review comment:
?
##########
File path: web/src/pages/Info/service.ts
##########
@@ -19,14 +19,14 @@ import { request } from 'umi';
// Waiting for api.
export const fetchInfoList = () => {
return request<Res<ResListData<NodeListData>>>(
- '/server_info?hostname={hostname}&page_size={page_size}&page={page}',
+ `/server_info`,
).then(({ data }) => ({
- data: data.rows,
+ data: data.rows
}));
};
export const fetchInfoData = () => {
Review comment:
remove this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
