spacewander commented on a change in pull request #3088:
URL: https://github.com/apache/apisix/pull/3088#discussion_r546553530
##########
File path: doc/control-api.md
##########
@@ -49,3 +49,9 @@ Here is the supported API:
Introduced since `v2.2`.
Return the jsonschema used by this APISIX instance.
+
+### GET /v1/server_info
Review comment:
I think it would be better to put this to plugin's own section. So that
the API in this page is builtin and will be provided whether you use the plugin
or not.
##########
File path: t/plugin/server-info.t
##########
@@ -133,3 +133,54 @@ integral
[error]
--- error_log
timer created to report server info, interval: 60
+
+
+
+=== TEST 3: get server_info from plugin control API
+--- yaml_config
+apisix:
+ id: 123456
+ enable_control: true
Review comment:
This configuration may confuses beginner, because the control server in
the test is hardcoded in APISIX.pm, instead of generating from config.yaml.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
