liuxiran commented on pull request #1087: URL: https://github.com/apache/apisix-dashboard/pull/1087#issuecomment-749312816
>  > > Hi @liuxiran, just enabled the **Update branch**, could we reconsider the PR? 1. I looked up several open source projects e.g: [apisix](https://github.com/apache/apisix/blob/0670eff88fdadb4d4a1d306086993557f2e3e3bf/.github/workflows/build.yml#L5) [skywalking](https://github.com/apache/skywalking/blob/e6265ba5be988c9b4c47252794a3684d544584d0/.github/workflows/ci-it.yaml#L21) [kubesphere](https://github.com/kubesphere/kubesphere/blob/d814d5db7bde49b44b31ad8ddf14da5517bc0c78/.github/workflows/build.yml#L6) they all run ci when push to master branch 1. the prs which does not have conflicts with the master branch, IMHO we did not need to do the rebase but this is just my personal opinion, we can listen to others‘ suggestions. ^_^ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
