spacewander commented on a change in pull request #2886:
URL: https://github.com/apache/apisix/pull/2886#discussion_r549537843
##########
File path: apisix/admin/plugins.lua
##########
@@ -23,6 +23,7 @@ local pcall = pcall
local table_sort = table.sort
local table_insert = table.insert
local get_uri_args = ngx.req.get_uri_args
+local v1 = require("apisix.control.v1")
Review comment:
It would be better to use `plugin.get_all` directly, instead of let
admin API depends on control API. And the fields returned by this one is
different from the control API one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
