membphis commented on a change in pull request #1093:
URL: https://github.com/apache/apisix-dashboard/pull/1093#discussion_r549600176
##########
File path: web/cypress/integration/route/create-edit-delete-route.spec.js
##########
@@ -74,18 +77,40 @@ context('Create and Delete Route', () => {
// go to step4
cy.contains('Next').click();
cy.contains('Submit').click();
- cy.contains('SubmitSuccessfully');
+ cy.contains('Submit Successfully');
// back to route list page
- cy.contains('Return Route List').click();
+ cy.contains('Goto List').click();
cy.url().should('contains', 'routes/list');
});
- it('delete the route', () => {
- cy.visit('/routes/list');
+ it('should edit the route', () => {
Review comment:
same issue
##########
File path: web/cypress/integration/route/create-edit-delete-route.spec.js
##########
@@ -18,23 +18,25 @@
context('Create and Delete Route', () => {
const name = `routeName${new Date().valueOf()}`;
+ const newName = `newName${new Date().valueOf()}`;
+ const sleepTime = 100;
beforeEach(() => {
// init login
cy.login();
});
- it('create route', () => {
+ it('should create route', () => {
Review comment:
Why do we need "should" here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
